search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

ICML Website Update #57

Closed kellinpelrine closed 1 year ago

kellinpelrine commented 1 year ago

Two things here:

  1. Merging main and fixing conflicts
  2. Anonymization
review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

netlify[bot] commented 1 year ago

Deploy Preview for go-attack-icml ready!

Name Link
Latest commit 95595b6fb56a421cc5031e2dfd71d5b99c06453f
Latest deploy log https://app.netlify.com/sites/go-attack-icml/deploys/63d2fdfa25d610000922e3ce
Deploy Preview https://deploy-preview-57--go-attack-icml.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tomtseng commented 1 year ago

lol this merge diff is pretty terrible, I wonder if it's easier to just start from scratch, i.e., create a branch off of main and make the appropriate anonymizing edits to Title.svelte, NavBar.svelte, and content.ts. @UFO-101 are those three files the only ones we'd need to edit?

EDIT: oh, Tony's suggestion of looking at the diff https://github.com/HumanCompatibleAI/KataGoVisualizer/compare/main...icml-website-update is helpful, that's probably better than starting from scratch. Never mind

kellinpelrine commented 1 year ago

Probably good idea in future, bunch more files had merge conflicts to resolve than just updating those 3.

lol this merge diff is pretty terrible, I wonder if it's easier to just start from scratch, i.e., create a branch off of main and make the appropriate anonymizing edits to Title.svelte, NavBar.svelte, and content.ts. @UFO-101 are those three files the only ones we'd need to edit?

EDIT: oh, Tony's suggestion of looking at the diff main...icml-website-update is helpful, that's probably better than starting from scratch. Never mind