Added baseline attack plots

AlignmentResearch / KataGoVisualizer

MIT License

3 stars 1 forks source link

Added baseline attack plots #6

Closed norabelrose closed 1 year ago

norabelrose commented 1 year ago

Right now the data is hardcoded into the notebook; should be able to fix this tomorrow if needed

UFO-101 commented 1 year ago

Looks good. Putting comment here because it's confusing to annotate the file directly:

Move imports to top + delete duplicate imports
Run through a python formatter (we use black for the main project)
Remove PAPER_STYLE so that fonts are consistent between plots.
Hardcoding the data seems not ideal, but I'm not sure how useful it will to be able to regenerate it.
Save output images to disk.

norabelrose commented 1 year ago

I added your suggestions an hour or two ago and I could have sworn I pushed it then but I guess not. Anyway, I pushed the changes now. Seems like you also made similar changes. ¯_(ツ)_/¯