sgf-viewer: Fix prepare_data parsing FAQ section, fix victim/adversary text spacing

AlignmentResearch / KataGoVisualizer

MIT License

3 stars 1 forks source link

sgf-viewer: Fix prepare_data parsing FAQ section, fix victim/adversary text spacing #88

Closed tomtseng closed 1 year ago

tomtseng commented 1 year ago

Fix 1

Add spacing between adversary and victim labels.

Before: Screen Shot 2023-06-05 at 18 16 11

After: Screen Shot 2023-06-05 at 18 16 31

Fix 2

prepare_data.py crashes on FAQ section because it expects certain fields for downloading SGFs. The FAQ doesn't have any associated SGFs, though, so prepare_data.py just shouldn't do any data preparation for the FAQ section.

The error prepare_data.py would hit:

Traceback (most recent call last):
  File "prepare_data/prepare_data.py", line 46, in <module>
    server = section["server"]

netlify[bot] commented 1 year ago

Deploy Preview for goattack ready!

Name	Link
Latest commit	309f5a316411d157297b492b89f1b4c2c3abfba5
Latest deploy log	https://app.netlify.com/sites/goattack/deploys/647e5f79357f1c0008bcdd39
Deploy Preview	https://deploy-preview-88--goattack.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

UFO-101 commented 1 year ago

Looks good. Thanks for the spacing fix. Looks like I added that bug in my last PR.

AlignmentResearch / KataGoVisualizer