search

AlignmentResearch / KataGoVisualizer

MIT License
3 stars 1 forks source link

Add new adversarial training plots designed for poster #92

Closed ed1d1a8d closed 10 months ago

ed1d1a8d commented 11 months ago

The poster plots have the same information as existing plots, just with different formatting to better suite a poster context.

Link to poster: https://icml.cc/media/PosterPDFs/ICML%202023/24524.png?t=1687531128.2757607

The reason there are two copies of each new plot (see ReviewNB) is because we use the second plot just for the legend (which we manually position in the poster).

We should merge https://github.com/AlignmentResearch/KataGoVisualizer/pull/93 into this PR first.

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

netlify[bot] commented 11 months ago

Deploy Preview for goattack ready!

Name Link
Latest commit 47dc2625451f24a23d57fa7efacf8cefaa116e3d
Latest deploy log https://app.netlify.com/sites/goattack/deploys/64d54a80cc4fc6000862c844
Deploy Preview https://deploy-preview-92--goattack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

review-notebook-app[bot] commented 11 months ago

View / edit / reply to this conversation on ReviewNB

tomtseng commented on 2023-07-17T23:47:57Z ----------------------------------------------------------------

Line #40.            # Move bottom axis up a tiny bit, adjust plot inside too

is this comment still up to date? where do we adjust the bottom axis?


review-notebook-app[bot] commented 11 months ago

View / edit / reply to this conversation on ReviewNB

tomtseng commented on 2023-07-17T23:47:58Z ----------------------------------------------------------------

Line #59.            plt.show()

this plot is a tiny bit taller than the poster plot from katago-new-ckpt-evals.ipynb, so the y-axis ticks are slightly misaligned


_ed1d1a8d commented on 2023-08-10T20:32:21Z_ ----------------------------------------------------------------

Ah wasn't sure how to fix this, since nominally the two plots should be the same height.

review-notebook-app[bot] commented 11 months ago

View / edit / reply to this conversation on ReviewNB

tomtseng commented on 2023-07-17T23:48:00Z ----------------------------------------------------------------

Line #29.            print(plt.gca().get_position())

why print this? was this to figure out how to position the legend?


_ed1d1a8d commented on 2023-08-10T20:33:57Z_ ----------------------------------------------------------------

Ah yeah this was used to figure out some positioning, but I forget what it was used for. Deleted for now.

review-notebook-app[bot] commented 11 months ago

View / edit / reply to this conversation on ReviewNB

tomtseng commented on 2023-07-17T23:48:01Z ----------------------------------------------------------------

Line #36.                    # hspace is needed due to latex shenanigans, only shows up in actual pdf

outdated comment? there's no hspace here


ed1d1a8d commented 10 months ago

Ah wasn't sure how to fix this, since nominally the two plots should be the same height.

View entire conversation on ReviewNB

ed1d1a8d commented 10 months ago

Ah yeah this was used to figure out some positioning, but I forget what it was used for. Deleted for now.

View entire conversation on ReviewNB

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.