Website brushup - Githubissues

UFO-101 commented 1 year ago

Change menu bar on mobile. Add links at top of the page. Lots of small aesthetic tweaks.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	5641bdf07292459cb138a67d4e7e0527f8075a1d
Latest deploy log	https://app.netlify.com/sites/goattack/deploys/64b6da8ab5af8e0008b57f07
Deploy Preview	https://deploy-preview-94--goattack.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tomtseng commented 1 year ago

Haven't looked at code yet, leaving some aesthetic comments:

hamburger nav menu for mobile works great!
for the new links at the top:
- Link to ICML poster says "Registration Required - You must be logged in to view this content." We may need to just upload the poster to this repo and link to that local version
- Link to OpenReview links to our old ICLR submission which is (1) an older worse version of our paper, and (2) has public comments indicating our rejection from ICLR. Don't think linking this has any benefit.
- It's not clear from the icons what the links to the video recording and (pending) blog post are. Maybe for we should just have text links "Paper", "Code", "Poster", "Talk", "Blog" and only have icons for the external media (Vice, FT, Ars Technica)

some things I noticed that aren't new to this PR:

after clicking some nav bar tabs to go to different sections, pressing the back button on the browser doesn't work as expected
on a narrow mobile screen, title/author would look better with slightly more left/right padding
on a narrow mobile screen, the "adversary" and "victim" labels below the games would look better with more left/right padding

ed1d1a8d commented 1 year ago

AlignmentResearch / KataGoVisualizer