Aliharu / Foundry-Ex3

Foundry module for Exalted Third Edition
MIT License
7 stars 12 forks source link

Active Effect Withering Damage bonus #45

Closed mrianmerry closed 1 month ago

mrianmerry commented 1 month ago

Hi all:

I'm trying to set up an active effect to allow me to toggle on the following Anima Power (from the Alchemicals Homebrew):

+ESS/2 to join battle, Accuracy, and w​ithering​ damage when at burning level or higher.

For now, I'm happy to manually manage the ESS/2 and Burning level or higher aspects, if the modifers can be applied to the correct rolls.

After much digging around in the system code, I found to my delight the section in config.js that, when added to the Active Effect, allows modifying values across the board for both Join Battle, and Accuracy:

"system.settings.rollsettings.attacks.bonus": "Ex3.Attacks"
"system.settings.rollsettings.joinbattle.bonus": "Ex3.JoinBattle"

This leaves me with an Active Effect as follows;

Screenshot 2024-09-21 at 14 23 56

Join Battle and Attacks bonuses are set to Add 1

Which works wonderfully. However, adding the withering damage effect is proving troublesome. The same section as above lists the following modifiers:

"system.settings.rollsettings.attackrollsettings.withering.bonus": "Ex3.WitheringAttacks",
"system.settings.rollsettings.attackrollsettings.withering.damage": "Ex3.WitheringAttackDamage",
"system.settings.rollsettings.attackrollsettings.withering.overwhelming": "Ex3.Overwhelming",

Which I can see are used in the Effects tab schema (defaulted to 0 of course), and which when manually changed in the Effects tab do the expected and update these values for all withering attacks.

However, updating them from the Active Effect does not appear to have any effect:

Screenshot 2024-09-21 at 14 27 01

Join Battle and Attacks bonuses are set to Add 1, and Withering Damage is set to Add 1000 for obvious recognition

Screenshot 2024-09-21 at 14 27 21

The Damage Dice field is notably missing the 1000 Dice bonus the Effect should be applying


Am I missing something in my setup, or is this particular modifier simply ignored in Active Effects? Thanks for your time.

mrianmerry commented 1 month ago

.... 🤦🏻 some more digging around after posting (obviously), and I realised the error that was throwing me off: I'd been using the attribute key system.settings.rollsettings.attackrollsettings.withering.damage (and in the screenshot above settings.rollsettings.attackrollsettings.withering.damage), but the correct attribute key was without the additional roll settings. So with the key set to system.attackrollsettings.withering.damage, the bonus is applied as expected.