Should return `addTransactionalDataSource` as promise

[TouchSek]

The problem is when we are using it with Nestjs, and using dataSourceFactory, it will resolve the wrong return type. since the dataSourceFactory need to return as Promise<DataSource>

For a temporary solution I have to do like:

dataSourceFactory: (options) => {
  if (!options) {
    throw new Error('Invalid options passed')
  }

  return addTransactionalDataSource(new DataSource(options)) as unknown as Promise<DataSource>
},

[neoatlan]

Please put async keyword to the arrow function

[chantouchsek]

But async alone is not working and I don't want to disable the eslint for that kind.

[neoatlan]

I think your project has a rule that forbids the async keyword on functions that only have synchronous operations. How about this way? return Promise.resolve(addTransactionalDataSource(...))

[TouchSek]

Thanks, man it's working.