search

Aliheym / typeorm-transactional

A Transactional Method Decorator for TypeORM that uses Async Local Storage or cls-hooked to handle and propagate transactions between different repositories and service methods.
MIT License
201 stars 27 forks source link

Not work if using custom repository #19

Closed vvtri closed 1 year ago

vvtri commented 1 year ago

Hi, I am using a custom repository with NestJs like in this post https://stackoverflow.com/a/72887316/19150323, when I call save method, it auto commit. This is my config, thanks you for making this library image image

Aliheym commented 1 year ago

Hi, thanks for your issue. This lib hasn't support custom repositories yet, but we have a PR for this feature. I will review and merge it as soon as possible on this week. I also want to add some tests for this.

vvtri commented 1 year ago

I have tried this PR https://github.com/Aliheym/typeorm-transactional/pull/14, but it doesn't seem to work

lukeurban commented 1 year ago

I can confirm that Custom Repositories are left out ;)

Aliheym commented 1 year ago

Hi guys, I added some basic tests to check custom repositories and with #14 PR it works well for me. I don't see any issues. Maybe you can give me some examples to check?

vvtri commented 1 year ago

Hi guys, I added some basic tests to check custom repositories and with #14 PR it works well for me. I don't see any issues. Maybe you can give me some examples to check?

I just made some basic test, maybe some mistakes were made. When this feature can be released ?

Aliheym commented 1 year ago

Hi guys, I added some basic tests to check custom repositories and with #14 PR it works well for me. I don't see any issues. Maybe you can give me some examples to check?

I just made some basic test, maybe some mistakes were made. When this feature can be released ?

In a few hours

Aliheym commented 1 year ago

New version with this feature was released.