Aliheym / typeorm-transactional

A Transactional Method Decorator for TypeORM that uses Async Local Storage or cls-hooked to handle and propagate transactions between different repositories and service methods.
MIT License
213 stars 28 forks source link

chore: addTransactionalDataSource param s order change #28

Closed isntkyu closed 1 year ago

isntkyu commented 1 year ago

Hello,

i m back-end developer in south korea.

i m not good at english , sorry :)

Thank you always

i met this tiny problem when i handled two datasource.

image

so i must do this

first datasource.

...
return addTransactionalDataSource(new DataSource(options))

and

second datasource.

image

look at this. 'name' property deprecated

because , my IDE infer 'name's type to Datasource in typeorm 'name'

image

Two simple solutions to a trivial problem.

One is export interface AddTransactionalDataSourceInput {..}

and the other is

merging this PR .

thank you