Alina-Khmilevska / UPSA-React

This repository contains the source code for the UPSA Pharmaceutical Organization's website, developed using the React library.
1 stars 0 forks source link

implemented data fetching for each city in LocalRepresentative component #29

Open na-talia opened 12 months ago

na-talia commented 12 months ago

The LocalRepresentatives component has been updated. It displays local team members obtained from the "upsa-api/team/lviv", "upsa-api/team/if" and "upsa-api/team/kharkiv" endpoints.

Loading and error handling have been added to each city for proper display. However, it's probably a good idea to create separate components for these functionalities and use them throughout the entire website as needed. This could help optimize the code and improve code readability.

na-talia commented 12 months ago

Currently, the first 4 members fetched from the backend are displayed. However, we probably need the ability to view all representatives from each city. Should we place team members in a slider? Or implement some other way to show the entire team? Any thoughts about it 👀

na-talia commented 12 months ago

I noticed that in some team member cards, the information is displayed not in the correct way. For example, in the first attached picture, justify-content: center is used, so the image on this card displayed lower than it should be.

padding1

In the second picture, I removed justify-content directly in the browser, and then the card displayed correctly.

padding2

It's a bit strange because we use .map(), and each card should be displayed in the same way. However, only some of them have this issue. 😵 I tried to find this CSS property in both LocalRepresentatives and TeamMemberCard, but I didn't find it. 😢

Could it be that the data in the backend is set up this way?

Alina-Khmilevska commented 12 months ago

@na-talia Ok, I agree with the slider, we need to implement this. But don't turn on autoplay, please add the dots

And about the pictures in the maps, let's leave it as it is for now, we will fix it at the stage of stylization

Alina-Khmilevska commented 12 months ago

I put the task on pause. Here it is still necessary to discuss with the president of the organization how to remove these blocks

Go to the next task, styling for example