AlinaMocanca / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations

In this first project, I look at two primary items with the main goal being to stop inefficient or bad practices early.

First, did you use divs, ids/classes to manage and organize your HTML. Great on this, Your div and class organization had everything I look for. Just make sure to follow the spec when it comes to the company/client's name.

Second is your CSS efficient and non-repetitive. CSS repetition just to needs to avoided. This project is small but as projects grow in size and complexity one of the goals is to type as little as possible to accomplish the job.

To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.

AlinaMocanca commented 6 years ago

Thank you for the review and the advices! I will try to put them in practice as much as possible and make attention to avoid repetition within the CSS file. I will also check flexbox.