Fix long blockquotes wrapping

Alir3z4 / html2text

Convert HTML to Markdown-formatted text.

alir3z4.github.io/html2text/

GNU General Public License v3.0

1.79k stars 273 forks source link

Fix long blockquotes wrapping #272

Closed hsmett closed 5 years ago

hsmett commented 5 years ago

Hello ! Here is an attempt to fix wrapping issues within blockquote. I don't know if this is the good way to go, I would love to get some feedback @Alir3z4 :) Thanks

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling 848265f075033089fca88b3bc4df151efc36b980 on hsmett:master into 3697acd58137bec34ef7dc812f69f3b14990a9bb on Alir3z4:master.

hsmett commented 5 years ago

Does this PR meet your expectations? :)

jdufresne commented 5 years ago

Those trailing whitespaces don't seem very logical to me neither, or I am missing something?

I agree. If removing them does not cause new unexpected test failures, I suggest we remove the trailing space.

hsmett commented 5 years ago

This seems to do the job.

jdufresne commented 5 years ago

This looks good to me. @Alir3z4 thoughts on merging this and cutting a release?

Alir3z4 commented 5 years ago

Oh, I missed this for the release. No worries,

We can merge this and do another release any other day.

hsmett commented 5 years ago

Thank you!