Simplify hn() function - Githubissues

Alir3z4 / html2text

Convert HTML to Markdown-formatted text.

alir3z4.github.io/html2text/

GNU General Public License v3.0

1.82k stars 273 forks source link

Simplify hn() function #277

Closed jdufresne closed 5 years ago

jdufresne commented 5 years ago

The new form:

Avoids the unnecessary range() call. On Python 2 this avoids building the data structure in memory.
Avoids the try/except block. The comparison is required either way, so just do that from the start.
Always explicitly return as a value. The old form sometimes fell through and returned None.

The new version is also slightly faster. Running the function through Python's timeit showed the following results:

old: 0.6434267910080962 new: 0.40665965899825096

coveralls commented 5 years ago

Coverage decreased (-0.005%) to 97.596% when pulling 2af6462b438f5f8971472cbdf1346ec2b93b4e8d on jdufresne:simplify into 3697acd58137bec34ef7dc812f69f3b14990a9bb on Alir3z4:master.