Alir3z4 / python-bitbucket

Python library to interact with BitBucket REST API
ISC License
1 stars 1 forks source link

Gather forces on bitbucket api implementation #5

Open guyzmo opened 7 years ago

guyzmo commented 7 years ago

hi,

I've made my own fork of Sheeprider/BitBucket-api to add a few features (like the forking ability). But that lib is relying mostly on the v1 API (even though v2 API does not cover 100% of the v1 features, it's a good idea to default to v2 and implement v1 for the missing bits).

I tried contacting Baptiste directly for transfering maintainership on his project, and he never got back to me.

Looking for alternatives, I found a more recent work pybitbucket. The maintainer is active, responsive ­— even though a bit busy with "life" — and is likely to integrate PR and push new releases, and it looks like it's part of the atlassian namespace (whatever that really means).

So my thoughts are that it'd be a good idea to gather all forces and make a single library a rather good one.

Alir3z4 commented 7 years ago

@guyzmo Thanks for bringing this up.

I've contacted Baptiste before and nothing was the result also contacted PyPI people, nothing there too. I use this package for most of my development work and tons of automation.

Before using this package, we've tried "pybitbucket" but to be honest its API was kind of confusing or weird in some places.

I've not push the changes to PyPI because I've not come up with a name that is less confusing to keep, You can see its issue here https://github.com/Alir3z4/python-bitbucket/issues/4

We're building our apps ~50 times per day and pull this package as dep from the git repo which is annoying.

We have some changes for this package for better maintenance and cleaner code and some new features that we'll make pull request for it later.

You have great projects on your profile and I see how it being used in https://github.com/guyzmo/git-repo, excellent work. Some part of our internal development works with re-implementing some of the stuff you've done on git-repo. We'd have used yours if we knew about it.

I'd love to have your permissions set on this project so you can update this project and help us for the code reviews on pull requests.

guyzmo commented 7 years ago

Before using this package, we've tried "pybitbucket" but to be honest its API was kind of confusing or weird in some places.

well, it's not that much confusing and I believe the author, @ibuchanan, is trying to improve on that. I agree the API can be improved (e.g.: by using a single instance as the entry point for the library). But a real advantage is that the library is part of the atlassian namespace on bitbucket, which I guess can be considered as giving it some authority.

Here you can have a look at a new branch with pending changes to refactor from bitbucket-api to pybitbucket.

I'm just waiting on @ibuchanan to accept my PR to add fork() support.

I've not push the changes to PyPI because I've not come up with a name that is less confusing to keep, You can see its issue here #4

I have the same problem with git-repo, which has a name conflict with google's repo project ☺

We're building our apps ~50 times per day and pull this package as dep from the git repo which is annoying.

well, you could always push an egg/wheel in the release section of the github.

We have some changes for this package for better maintenance and cleaner code and some new features that we'll make pull request for it later.

yup, this is why I've pinged you about it. Instead of making yet another fork, for a mostly APIv1 package, maybe it'd be a good idea to switch to a mostly APIv2 (with fallbacks on v1), which is more active. I believe it's a safer bet for the future.

You have great projects on your profile and I see how it being used in https://github.com/guyzmo/git-repo, excellent work.

thank you 😳

You have great projects on your profile and I see how it being used in https://github.com/guyzmo/git-repo, excellent work. Some part of our internal development works with re-implementing some of the stuff you've done on git-repo. We'd have used yours if we knew about it.

Well, I'd be happy to welcome more development and PRs to make git-repo better and more reliable! ☺

I'd love to have your permissions set on this project so you can update this project and help us for the code reviews on pull requests.

well, as a next step on bitbucket integration in git-repo I'll have to implement support for managing snippets, pull requests… and hopefully one day ssh keys etc. pybitbucket already features all of those, whereas bitbucket-api does not.

And I already had to patch both bitbucket-api and pybitbucket to have fork working, I'd rather avoid to write all the features! I'm already giving too much of my time to see gitlab snippets working from end to end.

N.B.: this is a 100% spare time project, I'm not being paid for it ☺