AlisterH / gwc

Gtk (formerly Gnome) Wave Cleaner
http://gwc.sourceforge.net/
Other
24 stars 7 forks source link

Key bindings should be reviewed #7

Open AlisterH opened 10 years ago

AlisterH commented 10 years ago
AlisterH commented 10 years ago
    case GDK_a:
        if (event->state & GDK_MOD1_MASK) /* Alt-a */
        manual_declick(NULL, NULL);
        else
        append_cdrdao(&audio_view);
        break;
AlisterH commented 5 years ago

N.B. that there is a section on hard coded key bindings in the manual which should be updated when we do any work on this.

Also, we should make the forward/backward skip (2 and 3) configurable, to cater for 78s and 45s, and other use cases.

AlisterH commented 3 years ago

Currently the menu presents Ctrl-S and Ctrl-A as shortcut keys but they don't work because of the hard-coded keybindings for A and S. If the user changes them to something else that doesn't clash with a hard-coded binding then that works.

This is ridiculous - we need to get rid of all the hard-coded bindings except maybe the space bar.

These are the documented hard-coded bindings, along with I guess [space]:

audrs23

This is the complete list:

[space]ls32djkrua

So these are the undocumented ones:

ljk

AlisterH commented 3 years ago

Also, we should make the forward/backward skip (2 and 3) configurable, to cater for 78s and 45s, and other use cases.

I suggest a "source rpm" setting.