Option to disable direct share

Aliucord / plugin-requests

Plugin requests for Aliucord

42 stars 3 forks source link

Option to disable direct share #1292

Open ourslfs opened 8 months ago

ourslfs commented 8 months ago

Discord Account

No response

What is it that you'd like to see?

After contacting someone, you get a list a discord contacts in your direct share menu. An option to disable such behavior would be nice(afaik you can disable Chooser Target Service Compat service with root, but you need root for that).

Go into more detail...

No response

Request Agreement

[X] I did indeed check to make sure my feature request is original!

rushiiMachine commented 8 months ago

This isn't something thats on by default

rushiiMachine commented 8 months ago

oh never mind i thought you were talking about proximity contacts

zt64 commented 8 months ago

I think this may require manifest modification? Maybe this should be transferred to the manager repository instead?

rushiiMachine commented 8 months ago

Yeah it definitely does. Problem is, adding patches like these on a case-by-case basis for a list of hardcoded ones is questionable. The other suggestion i remember was PIP which would require additions to the injector as well as manifest patch. Not sure what to do and how stuff like this should be handled properly

zt64 commented 8 months ago

Okay so after some looking it might be doable without modifying manifest. In AppActivity there's a call to updateDirectShareTargets which could be patched. Might have to also unregister any existing share targets