search

AliyunContainerService / kube-eventer

kube-eventer emit kubernetes events to sinks
Apache License 2.0
1.01k stars 278 forks source link

Add stdout sink / support promtail #181

Closed varac closed 2 years ago

varac commented 3 years ago

We're using promtail to aggregate logs so a sinple stdout sink would be perfect for promtail to gather the kube-eventer logs - or do they already show up in the pod stdout log ?

ringtail commented 3 years ago

We're using promtail to aggregate logs so a sinple stdout sink would be perfect for promtail to gather the kube-eventer logs - or do they already show up in the pod stdout log ?

I think a seperate log file would be better

varac commented 3 years ago

from https://12factor.net/logs:

A twelve-factor app never concerns itself with routing or storage of its output stream. It should not attempt to write to or manage logfiles. Instead, each running process writes its event stream, unbuffered, to stdout

varac commented 3 years ago

@ringtail Why do you think a logfile is better ? Promtail could handle both log files and stdout, so I don't care too much at the end.

ringtail commented 3 years ago

@ringtail Why do you think a logfile is better ? Promtail could handle both log files and stdout, so I don't care too much at the end.

I agree with you. Would you like to open a pr?