Closed Shuimo03 closed 1 year ago
func getCompression(opts url.Values) (kafka.CompressionCodec, error) { if len(opts["compression"]) == 0 { return kafka.CompressionNone, nil } comp := opts["compression"][0] switch comp { case "none": return kafka.CompressionNone, nil case "gzip": return kafka.CompressionGZIP, nil case "snappy": return kafka.CompressionSnappy, nil case "lz4": return kafka.CompressionLZ4, nil default: return kafka.CompressionNone, fmt.Errorf("Compression '%s' is illegal. Use none, snappy, lz4 or gzip", comp) } } func NewKafkaClient(uri *url.URL, topicType string) (KafkaClient, error) { ...... //这里有一个bug,getCompression最后还是会返回None,如果这里return出去就没有意义了 compression, err := getCompression(opts) if err != nil { return nil, err } ...... }
可以协助修复这个问题吗
OK,没有问题
不好意思,过去太久了,刚刚review了一下代码,是没有问题的,可能当时理解上有问题