Closed ZYecho closed 5 years ago
Merging #2915 into master will increase coverage by
0.04%
. The diff coverage is69.28%
.
@@ Coverage Diff @@
## master #2915 +/- ##
=========================================
+ Coverage 68.85% 68.9% +0.04%
=========================================
Files 291 291
Lines 18259 18387 +128
=========================================
+ Hits 12573 12670 +97
- Misses 4231 4247 +16
- Partials 1455 1470 +15
Flag | Coverage Δ | |
---|---|---|
#criv1alpha2_test | 38.68% <67.14%> (+0.34%) |
:arrow_up: |
#integration_test_0 | 36.41% <62.14%> (+0.15%) |
:arrow_up: |
#integration_test_1 | 35.84% <62.14%> (+0.17%) |
:arrow_up: |
#integration_test_2 | 36.39% <62.14%> (+0.2%) |
:arrow_up: |
#integration_test_3 | 35.93% <64.28%> (+0.19%) |
:arrow_up: |
#node_e2e_test | 34.43% <67.14%> (+0.22%) |
:arrow_up: |
#unittest | 27.78% <0%> (-0.23%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
daemon/mgr/image.go | 61.72% <100%> (+0.35%) |
:arrow_up: |
ctrd/image.go | 67.74% <69.06%> (+0.21%) |
:arrow_up: |
apis/server/utils.go | 71.15% <0%> (-3.85%) |
:arrow_down: |
daemon/mgr/container.go | 59.72% <0%> (-0.63%) |
:arrow_down: |
cri/v1alpha2/cri.go | 68.81% <0%> (-0.26%) |
:arrow_down: |
ctrd/container.go | 53.91% <0%> (+0.38%) |
:arrow_up: |
cri/stream/runtime.go | 70.23% <0%> (+2.38%) |
:arrow_up: |
ctrd/watch.go | 78.37% <0%> (+5.4%) |
:arrow_up: |
cri/stream/portforward/httpstream.go | 77.77% <0%> (+6.83%) |
:arrow_up: |
ctrd/snapshotter_key.go | 100% <0%> (+10%) |
:arrow_up: |
Signed-off-by: zhangyue zy675793960@yeah.net
Ⅰ. Describe what this PR did
add a doc to describe this feature https://www.yuque.com/zhangyue-jlgo3/kb/epa5ml
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
using current test case.
Ⅳ. Describe how to verify it
hello-world only has one layer, and we can see that the layer don't any any fc ref point to it, so it will be deleted by containerd gc.
and other content keep original
Ⅴ. Special notes for reviews
when manifest is in schema 1 (application/vnd.docker.distribution.manifest.v1+prettyjws), this feature is not enable now.