Closed ZYecho closed 5 years ago
Merging #2933 into master will decrease coverage by
0.11%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
- Coverage 68.18% 68.07% -0.12%
==========================================
Files 291 291
Lines 18339 18354 +15
==========================================
- Hits 12505 12495 -10
- Misses 4376 4394 +18
- Partials 1458 1465 +7
Flag | Coverage Δ | |
---|---|---|
#criv1alpha2_test | 34.79% <16.66%> (-0.02%) |
:arrow_down: |
#integration_test_0 | 36.02% <50%> (-0.01%) |
:arrow_down: |
#integration_test_1 | 35.6% <83.33%> (+0.1%) |
:arrow_up: |
#integration_test_2 | 35.96% <41.66%> (-0.02%) |
:arrow_down: |
#integration_test_3 | 35.58% <66.66%> (+0.02%) |
:arrow_up: |
#node_e2e_test | 34.09% <16.66%> (-0.12%) |
:arrow_down: |
#unittest | 27.94% <0%> (-0.03%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
daemon/mgr/image.go | 59.13% <ø> (+0.29%) |
:arrow_up: |
daemon/mgr/volume.go | 83% <100%> (+0.34%) |
:arrow_up: |
daemon/mgr/container_commit.go | 57.14% <100%> (+1.04%) |
:arrow_up: |
daemon/mgr/container.go | 59.43% <100%> (-0.71%) |
:arrow_down: |
daemon/mgr/container_exec.go | 80% <100%> (+0.32%) |
:arrow_up: |
daemon/mgr/container_copy.go | 57.98% <100%> (+0.5%) |
:arrow_up: |
daemon/mgr/image_load.go | 58.33% <100%> (+1.81%) |
:arrow_up: |
daemon/mgr/image_save.go | 55.55% <100%> (+5.55%) |
:arrow_up: |
apis/server/utils.go | 71.15% <0%> (-3.85%) |
:arrow_down: |
ctrd/container.go | 52% <0%> (-2.3%) |
:arrow_down: |
... and 5 more |
Thanks for your contribution. 🍻 @ZYecho While we thought PR TITLE could be more specific, longer than 20 chars. Please edit this PR title instead of opening a new one. More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
Signed-off-by: zhangyue zy675793960@yeah.net
Ⅰ. Describe what this PR did
according docker’s event, add more events to help debug.
Ⅱ. Does this pull request fix one issue?
fix #2932
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
No need.
Ⅳ. Describe how to verify it
None.
Ⅴ. Special notes for reviews
after this pr was merged, the events below are supported.
Container
Image
Volume
Network