codecov[bot]
commented
5 years ago Codecov Report
Merging #2999 into master will decrease coverage by
1.61%. The diff coverage is100%.
@@ Coverage Diff @@
## master #2999 +/- ##
==========================================
- Coverage 67.41% 65.79% -1.62%
==========================================
Files 291 291
Lines 18660 18666 +6
==========================================
- Hits 12579 12282 -297
- Misses 4572 4954 +382
+ Partials 1509 1430 -79| Flag | Coverage Δ | |
|---|---|---|
| #criv1alpha2_test | 34.53% <37.5%> (-0.12%) |
:arrow_down: |
| #integration_test_0 | 36.45% <100%> (+0.04%) |
:arrow_up: |
| #integration_test_1 | ? |
|
| #integration_test_2 | 36.38% <100%> (+0.02%) |
:arrow_up: |
| #integration_test_3 | 35.84% <100%> (?) |
|
| #node_e2e_test | 33.99% <37.5%> (-0.23%) |
:arrow_down: |
| #unittest | 26.67% <0%> (-0.01%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| apis/server/router.go | 91.66% <100%> (+0.28%) |
:arrow_up: |
| ctrd/image_commit.go | 0% <0%> (-65%) |
:arrow_down: |
| daemon/mgr/container_commit.go | 0% <0%> (-54.72%) |
:arrow_down: |
| daemon/mgr/container_copy.go | 38.95% <0%> (-17.45%) |
:arrow_down: |
| apis/server/copy_bridge.go | 46.93% <0%> (-16.33%) |
:arrow_down: |
| daemon/mgr/container_exec.go | 64.78% <0%> (-14.79%) |
:arrow_down: |
| pkg/reference/def.go | 77.77% <0%> (-11.12%) |
:arrow_down: |
| daemon/mgr/network_utils.go | 30.43% <0%> (-10.87%) |
:arrow_down: |
| daemon/mgr/events.go | 84.41% <0%> (-9.1%) |
:arrow_down: |
| apis/server/network_bridge.go | 57.25% <0%> (-8.88%) |
:arrow_down: |
| ... and 30 more |
Signed-off-by: zhuangqh zhuangqhc@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
add filter when graceful shutdown server
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews