search

AlkaMotors / AM32-MultiRotor-ESC-firmware

Firmware for stm32f051 based speed controllers for use with mutirotors
GNU General Public License v3.0
754 stars 266 forks source link

Add AM32 identifier #53

Closed DusKing1 closed 2 years ago

DusKing1 commented 2 years ago

This should help end-users more clearly identify which firmware is being flashed, especially for those who can't distinguish AM32 and other firmware (e.g. BLHeli_32).

cruwaller commented 2 years ago

I think all the common info should be moved into makefile to keep maintaining easier :)

Good idea 👍

DusKing1 commented 2 years ago

Yeah I'm currently looking into this (combine all three makefiles into one) but haven't got an idea how to do that. Do you have any solution @cruwaller ?

cruwaller commented 2 years ago

I have and I can open a PR later. I think it is good good idea to keep that kind of PRs small and focused to one thing ar the time :)

cruwaller commented 2 years ago

Oh, it is enough to just cut those lines and paste into makefile before include lines

DusKing1 commented 2 years ago

Are you using linux env to build firmware?

DusKing1 commented 2 years ago

I have and I can open a PR later. I think it is good good idea to keep that kind of PRs small and focused to one thing ar the time :)

yep, let's get this merged so can avoid future code conflicts

cruwaller commented 2 years ago

Are you using linux env to build firmware?

Yes

DusKing1 commented 2 years ago

Anyway, it'll be interesting to see your solution on multi makefile combination, and I think maybe I should do some fix to the CI, since it doesn't report that your F051 was failed to build.

AlkaMotors commented 2 years ago

merged, thanks dusking