search

AlkaMotors / AM32-MultiRotor-ESC-firmware

Firmware for stm32f051 based speed controllers for use with mutirotors
GNU General Public License v3.0
754 stars 266 forks source link

Cleanup #56

Closed giacomo892 closed 2 years ago

giacomo892 commented 2 years ago

Substitute #55 . PR to master this time

giacomo892 commented 2 years ago

Hi @AlkaMotors can this be merged?

AlkaMotors commented 2 years ago

Sorry i didn't get a chance to really look it over. It looks like all the comments for other input types are removed? I see lots of lines changed where nothing appears to be changed at all?

giacomo892 commented 2 years ago

@AlkaMotors yeah and those are removing of white space at the end of the line

cruwaller commented 2 years ago

@AlkaMotors yeah and those are removing of white space at the end of the line

you also removed newlines at the end of the files. You should keep those.

giacomo892 commented 2 years ago

@AlkaMotors yeah and those are removing of white space at the end of the line

you also removed newlines at the end of the files. You should keep those.

Can you point out where I did it? Cannot see it

giacomo892 commented 2 years ago

@cruwaller Done. The code needs mayor cleanup, we should start from something :)

AlkaMotors commented 2 years ago

I agree... It does need cleanup, in small steps so I can understand it! The code for those protocols are gone so we can get rid of the commented lines now.