search

Alkaar / resy-booking-bot

🔫 Helps to snipe hard to get reservations at restaurants that use resy
407 stars 214 forks source link

Works great but getting Output is throwing an error. #60

Open NightPants opened 2 years ago

NightPants commented 2 years ago

First off, love this works great!

I get this error when running "ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console..."

It appears that the only thing is impacts is the debug/output. any thoughts on what would resolve it? it would be very nice to see success/failures

Thanks again!

Alkaar commented 2 years ago

I've seen this happen to me rarely. Usually rerunning it fixes it. You may want to restart your IDE or refresh your dependencies to get it to pick up.

Alkaar commented 2 years ago

Haven't heard back on this. LMK if this addresses your issue or not. Otherwise, I will close this out.

NightPants commented 2 years ago

Sorry for the delay, I tried to few times to restart times to the IDE and also reload the dependencies and I was getting the same error.

I am using VS code, and it could probably be related to that but what ended up working for me was changing this code in the build.sbt file:

"org.apache.logging.log4j" % "log4j-core" % "2.13.0",// % Runtime, //"org.apache.logging.log4j" % "log4j-core" % "2.13.0" % Runtime, I commented out the "Runtime" and that worked for me, but again it pobably was just VS code issue with the Log4j2 logger.

Alkaar commented 1 year ago

That is interesting. I'll try messing with it a bit. As long as it works with sbt then I think it's fine since that is the "Scala way". The % Runtime scopes it so it only uses that library under certain contexts. So removing % Runtime makes it always available. So it's not preferred but if it helps compatibility then maybe it's worth it.

Alkaar commented 1 year ago

So this is the documentation where I determined how to pull down the log4j dependencies 👉 https://logging.apache.org/log4j/scala/index.html screenshot

No one else has reported the issue so I'm going to leave it as is for now. There were a few version bumps since you last reported this so I'll probably make a small fix and see if that changes anything. If it's still acting weird for you, feel free to LMK.

Alkaar commented 1 year ago

Made a PR to merge in the version bump changes 👉 https://github.com/Alkaar/resy-booking-bot/pull/85