Alkl58 / NotEnoughAV1Encodes

GUI for AV1 (aomenc, rav1e & svt-av1)
MIT License
536 stars 24 forks source link

Encoder Speed Name gets stuck after using Encoder with Speed level Name #158

Closed MrBullet75 closed 5 months ago

MrBullet75 commented 8 months ago

Source and Destination defined or not, when a video encoder is selected, which uses words for levels rather than numbers, the selected level will not be replaced by the corresponding number when switching back to an encoder that uses Speed level numbers. Not sure if there is any impact on the actual encoding. When switching back to an encoder that uses words for speed levels it works again, but getting to see the numbered encoder speeds requires a restart of the software.

Steps to reproduce the behavior:

  1. Go to 'Video'
  2. Click on 'Encoder'
  3. Select 'x265 (HEVC FFmpeg)', 'x264 (AVC FFmpeg)', 'QuickSync (AV1 Intel HW)', 'NVENC (AV1 NVIDIA HW)' or 'AMF (AV1 AMD HW)'
  4. Select any 'Speed' option
  5. Click on 'Encoder' again
  6. Select 'aom (AV1 FFmpeg)', 'rav1e (AV1 FFmpeg)', 'svt-av1 (AV1 FFmpeg)', 'vpx-vp9 (VP9 FFmpeg)', 'aomenc (AV1)', 'rav1e (AV1)' or 'svt-av1 (AV1)'
  7. Select any 'Speed' option
  8. See Speed Preset Name from previous encoder not changing

1) Shows the Video Tab right after startup: image 2) Speed can be changed and Number changes accordingly: image 3) Also works with another Encoder: image 4) Encoder selected with word describing Speed: image 5) Speed changes accordingly: image 6) Also works with other Encoder: image 7) Encoder with Number for Speed still shows word: image 8) Speed change does not update the word: image 9) Other Encoder with numbered Speed: image 10) Encoder switched to worded Speed: image 11) Speed changes accordingly: image

Desktop:

Alkl58 commented 8 months ago

Thanks for reporting this issue.

This issue should only affect the user interface and not the actual encode, thats why I won't release a hotfix.

I already pushed a fix, this will be included in the next release.

MrBullet75 commented 8 months ago

Thanks for reporting this issue.

This issue should only affect the user interface and not the actual encode, thats why I won't release a hotfix.

I already pushed a fix, this will be included in the next release.

I thought so too but I didn't know. Btw I really like the whole project. Keep it up :)

Alkl58 commented 5 months ago

Fixed in the new v2.1.7 release.