Alkl58 / NotEnoughAV1Encodes

GUI for AV1 (aomenc, rav1e & svt-av1)
MIT License
543 stars 24 forks source link

[BUG] Running queue element not present in gui after edit #74

Closed Palulukas closed 2 years ago

Palulukas commented 2 years ago

Describe the bug While running a encode, you can edit queue elements, even the running one. I've done it because I saw that I set a wrong video option. Excepting to restart the encode with new settings, the element dissappeared from the queue but my computer kept encoding "something".

To Reproduce Steps to reproduce the behavior:

  1. Add element to queue
  2. Start encode
  3. Edit currently encoded element in queue
  4. Save edits and find yourself the messing element in queue :D

Expected behavior Not entirely clear but I would expect to restart the current encoding with the fresh settings.

Screenshots See below. Please don't get irritated by low cpu usage. In the moment I took the screenshot, the invisible encoding must have finished. ;-) But as you can the in the diagrams, the cpu usage was all cores maxed out just a few seconds ago.

Log File If possible, upload the log generated by the program here.

Desktop (please complete the following information):

Alkl58 commented 2 years ago

Oh well...

Yeah, you aren't supposed to edit queue elements, when the encode is running. When clicking edit item, it moves the item from the queue, to the "GUI" if it makes sense and deletes the queue item. The idea was, that users could edit the item and then re-add it to the queue.

I should probably disable those options, once the encode has started - the queue system itself needs improvment aswell, as it doesn't check for new queue items, after the encode has started.

Alkl58 commented 2 years ago

The new releases prevents users doing what you did ^^

Just as final note: After clicking edit item, you have to re-add it with "Add to Queue".

Palulukas commented 2 years ago

Hello Alkl58, thank you for your explanations. Maybe you can modify the "Add to Queue" button to "Re-Add to Queue" while editing a queued item? Or something to remind the user to re-add after the editing is done.

Regards