All-Hands-AI / OpenHands

🙌 OpenHands: Code Less, Make More
https://all-hands.dev
MIT License
35.64k stars 4.05k forks source link

[frontend] Improve ShareOpenDevin User Experience #3010

Closed xingyaoww closed 1 month ago

xingyaoww commented 3 months ago

What problem or use case are you trying to solve?

Describe the UX of the solution you'd like

Optional

These are just my quick thoughts -- let me know what y'all think!

Do you have thoughts on the technical implementation?

Relevant file to change: https://github.com/OpenDevin/OpenDevin/tree/main/frontend/src/components/modals/feedback

Describe alternatives you've considered

Additional context

tobitege commented 3 months ago

We really could use a "Notifications" sidebar where this info could be shown to the user. How/where to store is another question.

tobitege commented 3 months ago

@amanape is there a way to display slightly differently in that the toast stays and has an extra "cross" close button? That way the user can take their time to copy the info and the close button cannot be ignored then.

amanape commented 3 months ago

These are good changes, some comments:

There needs to be a way to track what chat histories I've shared.

Since we don't have any form of permanent persistence like a database, I think the best way would be storing it in local storage. This has the downside of clearing if the user changes browser or resets cache. Did you have something else in mind?

instead of providing a password with the URL, maybe the user only needs to provide their email on the website and receive an email authentication or something

Good idea, but keep in mind some extra effort (e.g., also setting up some form of persistence to retrieve the currently stored code to verify it is the same that was entered, setting up and verifying a sender email, etc...)

@tobitege Yes I am pretty sure the library we are using supports this to some extent. If not, I know of other libraries that do.

I just so happen to be updating tests and refactoring some things related to feedback #2997, so I should be able to tick off a few boxes here at the same time.

xingyaoww commented 3 months ago

Since we don't have any form of permanent persistence like a database, I think the best way would be storing it in local storage. This has the downside of clearing if the user changes browser or resets cache. Did you have something else in mind?

I think in the simplest form, we can just make these info stored in the current browser session (like what we are doing with the API key - I think that just gets stored in my browser?) WDYT?

amanape commented 3 months ago

I think in the simplest form, we can just make these info stored in the current browser session (like what we are doing with the API key - I think that just gets stored in my browser?) WDYT?

Yes exactly

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

xingyaoww commented 1 month ago

This should mostly been resolved a while ago - i think we can close this for now and create new issue if we want more feature here