search

All-Hands-AI / OpenHands

🙌 OpenHands: Code Less, Make More
https://all-hands.dev
MIT License
37.37k stars 4.23k forks source link

[frontend]: Push to Github button should only push branch, but not creating a PR #5179

Closed xingyaoww closed 5 hours ago

xingyaoww commented 4 days ago

What problem or use case are you trying to solve?

After clicking the "push to github" button, the frontend will automatically send a message asking the agent to push stuff to github AND create a PR.

image

image

Describe the UX of the solution you'd like

We should have two separate buttons for the functionality of "push to remote branch", AND, "push & create a new PR" - so we don't accidentally create new PR when not intended.

Do you have thoughts on the technical implementation?

Describe alternatives you've considered

Additional context

rbren commented 4 days ago

I actually disagree with this--I generally want it to open the PR. But I think adding some customizability here would be good

Edit: ah I see you're proposing a second button. That seems reasonable

xingyaoww commented 4 days ago

We could also do some sort of checkbox? But it might be tricky to place it near the button.. Let's ask OpenHands try to implement the two button approach and see how it'd go! @openhands-agent

github-actions[bot] commented 4 days ago

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] commented 4 days ago

A potential fix has been generated and a draft PR #5181 has been created. Please review the changes.