All-Hands-AI / OpenHands

🙌 OpenHands: Code Less, Make More
https://all-hands.dev
MIT License
37.8k stars 4.27k forks source link

[Bug]: lint-fix workflow is failing frontend and python steps #5337

Closed enyst closed 1 day ago

enyst commented 2 days ago

Is there an existing issue for the same bug?

Describe the bug and reproduction steps

In ./github/workflows, we have a fix-lint workflow which the human users can run on a PR by applying a label (lint-fix). This workflow doesn't work right, on two issues:

1) Frontend linting from this workflow can give errors that the regular lint workflow that runs on CI doesn't. Find the regular lint and make sure that lint-fix fixes the same thing. Maybe it needs to use the same deps, or maybe the command it runs needs to be the same.

2) If frontend fix lint step fails, then the python attempt to fix python linting never gets to run. This is the wrong behavior, we need to run the python step.

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

github-actions[bot] commented 2 days ago

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] commented 2 days ago

A potential fix has been generated and a draft PR #5338 has been created. Please review the changes.