search

AllMangasReader-dev / AMR

AllMangasReader developer branch
www.allmangasreader.com
Other
99 stars 56 forks source link

Bookmarks don't work at all #103

Open metazoxan opened 10 years ago

metazoxan commented 10 years ago

braiam keeps saying to try posting issues on GitHub so I'm giving it a try.

Anyway the problem is the Bookmarks are all messed up. Sometimes when I try to get rid of one it won't go away or it deletes the one above it instead and whenever I click on a bookmark it goes to whatever is on the bottom of the list instead. For example I have a chapter of Zettai Karen Children at the bottom of my bookmark list. No matter what link I click on it goes to that chapter of Zettai Karen Children.

mexicano21 commented 10 years ago

Maybe we should get rid of this feature? I mean, we already have a browser to save links. Or perhaps, we could use the browser bookmark API (there should be one) in AMR instead of having our own buggy bookmark (from now on referred as "bugmark") system.

2014-05-10 0:43 GMT-03:00 metazoxan notifications@github.com:

braiam keeps saying to try posting issues on GitHub so I'm giving it a try.

Anyway the problem is the Bookmarks are all messed up. Sometimes when I try to get rid of one it won't go away or it deletes the one above it instead and whenever I click on a bookmark it goes to whatever is on the bottom of the list instead. For example I have a chapter of Zettai Karen Children at the bottom of my bookmark list. No matter what link I click on it goes to that chapter of Zettai Karen Children.

Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/103 .

Fábio de Godoy http://www.guiadosquadrinhos.com/capas-dos-gibis-da-colecao/godoy-rodrigues-da-silva/45583

metazoxan commented 10 years ago

The thing I always liked about bookmarks though is I could save my progress with a manga and not have it red all the time. For example lets take Hayate the Combat butler. I'm no where near up to the latest chapter with that. but I don't want it to sit at the top of the list as a red one all the time. Besides that if for any reason I decide to stop reading a specific manga for a while I can leave the last read chapter in my bookmarks. Plus there were times that leaving notes on a bookmark was convenient.

So I'd prefer is AMR had at least some kinda feature with a similar function.

ioannis-e commented 10 years ago

Why dont use the categories feature for that ? You can create a custom category and drag all your slow manga in that category and show/hide that category when you feel like it. image

braiam commented 10 years ago

There is a bookmark API just that it wouldn't work on specific scans (well, it can, but will be just links to the raw jpg). I'm going to disable the feature everywhere in the mean time (with a switch of course) so people can focus on other things. What everyone thinks?

braiam commented 10 years ago

BTW, the bookmark.js file is a holy mess https://codeclimate.com/github/AllMangasReader-dev/AMR/js/bookmarks.js, so I wouldn't want to tangle myself with it.

metazoxan commented 10 years ago

I suposse I could use a custom category. I just always kinda liked being able to simply click the little star to save my place.

mexicano21 commented 10 years ago

We could not put the categories in the manga reading toolbar? That would make up for bookmark removal and still be just one click away for you.

2014-05-10 14:28 GMT-03:00 metazoxan notifications@github.com:

I suposse I could use a custom category. I just always kinda liked being able to simply click the little star to save my place.

Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/103#issuecomment-42748461 .

Fábio de Godoy http://www.guiadosquadrinhos.com/capas-dos-gibis-da-colecao/godoy-rodrigues-da-silva/45583

metazoxan commented 10 years ago

That does sound interesting. At the very least it's certainly worth a try especially if the bookmark system is such a mess.

Maybe Bookmarks could also be included as one of the native Categories. Also while we're on this subject is a category is striked through (meaning ti's excluded from the list) do update notifications still show up normally? I haven't used categories too much so I'm not sure and I didn't see this mentioned in the FAQ.