AllMangasReader-dev / AMR

AllMangasReader developer branch
www.allmangasreader.com
Other
97 stars 54 forks source link

Set max-width in the navbar to prevent the bar growing without control. #47

Closed braiam closed 11 years ago

braiam commented 11 years ago

Some chapters have extremely large names that in small screens makes the bar grow vertically.

braiam commented 11 years ago

Just where are the css rules add? :confused:

plduhoux commented 11 years ago

On what websites do you have the issue ??

braiam commented 11 years ago

@plduhoux check RHS "Hayate no Goutoku" and FTH "Liar's Paradox", the select just grow horizontally until it fill the screen (I have a small screen) making the navBar fill 3 rows instead one. I can fix it manually when reading, but it could be nice that in case that the select were too big for the screen it doesn't affect the icons position.

braiam commented 11 years ago

I found this: I will test later http://stackoverflow.com/a/15641292/792066

braiam commented 11 years ago

you really gotta be kidding me... image

I think I will use ´$(document).width() - 450´ instead.

plduhoux commented 11 years ago

Waw ??!! weird that worked for now... will have a look at it...

bessx commented 11 years ago

Is there no way to use some sort of overflow for this sort of thing?

mexicano21 commented 11 years ago

I didn't understand the problem with the image: the .

2013/3/28 Someone516 notifications@github.com

Is there no way to use some sort of overflow for this sort of thing?

— Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/47#issuecomment-15610119 .

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21

braiam commented 11 years ago

I've set the max-width as the total width using $(document).width() with minus the icons/buttons width (more or less 450 px). When we do the translations of the buttons this may change, may not, and also it doesn't change upon re-size, so feel free to propose another solution.

plduhoux commented 11 years ago

I prefer it like that effectively... moreover, i tested it on a very wide screen... so it was not really representative...

braiam commented 11 years ago

Well, I set it up that in any screen it ends with less than the total screen width, which probably is the best for all screens.