search

AllMangasReader-dev / AMR

AllMangasReader developer branch
www.allmangasreader.com
Other
97 stars 54 forks source link

AMR 1.5.1 issuing "Unexpected token <" errors #60

Closed deVars closed 11 years ago

deVars commented 11 years ago

Steps to reproduce: 1.) Browse to yahoo landing page or aol landing page (google seem to fix this) 2.) Show developer console

Console will report: Uncaught SyntaxError: Unexpected token <

fuzetsu commented 11 years ago

This is a strange one, I've tracked it down to back.js

chrome.extension.sendRequest({action: "pagematchurls", url: window.location.href }, function(response) {
  if (response.isOk) {
    removeBanner();
    initPage();
  }
});

commenting this part out at the very bottom of back.js removes the warning about the uncaught syntaxerror (at least on canary).

It doesn't' seem to affect functionality though (the error I mean).

Anyone have any clue what's going on?

EDIT:

The problem seems to occur after the call to $.loadScript in background.js when the request for "pagematchurls" is made.

I added an exit condition for when the var _isOk is false so that it won't happen on unrelated sites (eq. aol, yahoo) but it still happens on places where there is a matching implementation (eq. egscans.com).

fuzetsu commented 11 years ago

I've checked a few other sites and it looks like its not happening anywhere else. The issue on egscans.com is unrelated to this extension. I declare this issue resolved.