search

AllMangasReader-dev / AMR

AllMangasReader developer branch
www.allmangasreader.com
Other
99 stars 56 forks source link

improved the loading of content scripts #86

Closed fuzetsu closed 10 years ago

fuzetsu commented 10 years ago

Instead of always loading jquery, both its plugins, and back.js (a fairly large file with a lot of functions) on every page we can instead just load the 9 line file testPage.js which will send a request to the background page to inject the necessary content scripts along with the implementation script. Non-manga pages can be identified in ~ 40ms without loading any unnecessary files (from my testing).

This is my suggestion for a new method of loading the content scripts and making it a little bit more efficient. Any thoughts on it? If everyone agrees then this pull request should be merged into the develop branch.

fuzetsu commented 10 years ago

I would appreciate it someone else could test it a bit too, just checkout the branch and try loading a few of your manga pages. It works fine for the ones I've tested but it's better to be safe than sorry!

braiam commented 10 years ago

I'll be running this for 7 days, if nothing goes wrong, I'll give my ok. I would like this to roll out to the stable channel since it would greatly improve the general perfomance of our users (also, has passed couple moons since last release).

fuzetsu commented 10 years ago

Sounds good, I'll stay on this branch as well. We'll see how it goes..

braiam commented 10 years ago

I think we could merge this, anyone second? Just press the "Merge pull request" button without hesitation.

fuzetsu commented 10 years ago

Sounds good to me, I haven't noticed any issues. I'll merge it then!