braiam
commented
10 years ago How to reproduce?
Closed inorichi closed 10 years ago
braiam
commented
10 years ago How to reproduce?
inorichi
commented
10 years ago Restart a manga reading status, use the mark as read button and with console.log look at the attributes of that manga.
Or print mangaList in the console and search for that manga.
braiam
commented
10 years ago Do I need to remove the manga and re-add it for the undefined to go away? Applied the patch, and still.
inorichi
commented
10 years ago Did you repeat the same steps after applying the patch?
It's working for me.
braiam
commented
10 years ago Yeah, only after removing it the issue went away. Well, will push the patch, anyways.
inorichi
commented
10 years ago Hm... weird. I didn't delete the manga.
braiam
commented
10 years ago @inorichi can you push all the issues you have fixed, or should I pull them (if the commit message makes any sense)? Or you will open issues and pull requests?
inorichi
commented
10 years ago There aren't more issues fixed in my repository. They're for the google drive synchronization @arran4 and me are doing (mostly him). And of course it isn't ready to be pushed here. :)
I left a message in the forum talking about this.
arran4
commented
10 years ago No where near ready!
On Tue, Dec 10, 2013 at 10:42 AM, inorichi notifications@github.com wrote:
There aren't more issues fixed in my repository. They're for the google drive synchronization we and @arran4 https://github.com/arran4 are doing (mostly him). And of course it isn't ready to be pushed here. :)
I left a message in the forum talking about this.
— Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/pull/95#issuecomment-30186207 .
I think this is not a big deal, but it may lead to some bugs in the future.