search

AllMangasReader-dev / AMR

AllMangasReader developer branch
www.allmangasreader.com
Other
97 stars 54 forks source link

Update notifications from window.webkitNotifications to chrome.notifications #98

Open mexicano21 opened 10 years ago

mexicano21 commented 10 years ago

In Chrome 35.0.1897.2 dev-m window.webkitNotifications was removed, breaking the background page when the notifications are active and a new chapter is found, hence the need to update to chrome.notifications.

braiam commented 10 years ago

I see what you did there, can you add comments so people knows what's going on?

mexicano21 commented 10 years ago

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero notifications@github.com:

I see what you did there, can you add comments so people knows what's going on?

Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274 .

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21

braiam commented 10 years ago

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 notifications@github.com:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero notifications@github.com:

I see what you did there, can you add comments so people knows what's going on?

Reply to this email directly or view it on GitHub< https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21

— Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643456 .

Braiam Peguero

braiam commented 10 years ago

Just push another edit with the comments, there's no need to amend the one you did.

2014-03-25 22:14 GMT-04:00 Braiam Peguero braiamp@gmail.com:

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 notifications@github.com:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero notifications@github.com:

I see what you did there, can you add comments so people knows what's going on?

Reply to this email directly or view it on GitHub< https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21

— Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643456 .

Braiam Peguero

Braiam Peguero

mexicano21 commented 10 years ago

All comented now. There are almost much comments as code lines now, lol. I hope it's clear enough =)

2014-03-25 23:15 GMT-03:00 Braiam Peguero notifications@github.com:

Just push another edit with the comments, there's no need to amend the one you did.

2014-03-25 22:14 GMT-04:00 Braiam Peguero braiamp@gmail.com:

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 notifications@github.com:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero notifications@github.com:

I see what you did there, can you add comments so people knows what's going on?

Reply to this email directly or view it on GitHub<

https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21

Reply to this email directly or view it on GitHub< https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643456>

.

Braiam Peguero

Braiam Peguero

Reply to this email directly or view it on GitHubhttps://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643579 .

Fábio de Godoy http://www.animenewsnetwork.com/MyManga/?user=mexicano21