search

AllSpiceIO / cofactr-cogs

Compute cost of goods sold (COGS) in AllSpice Actions using Cofactr.
MIT License
0 stars 0 forks source link

Customize not-a-part prefix #5

Open jtran opened 1 month ago

jtran commented 1 month ago

Currently, any part number starting with NOTAPART isn't attempted to be fetched from the API. We should allow users of the custom action to control this, ideally with multiple prefixes.

kdumontnu commented 1 month ago

It's worth considering whether this should be done in the BOM action instead or in addition to here.

It's closely related to this issue: https://github.com/AllSpiceIO/py-allspice/issues/82

However, it's likely that having this control at both stages could be helpful for the user. For instance, they may want to generate a BOM that includes some parts for other uses, but not include in the cost.

jtran commented 1 month ago

I think that if we have the feature, there should be a way to control it. Otherwise, the string is hardcoded. So unless stated otherwise, I think the original issue description stands.