Add support for Hotspot COR LED

AllStarLink / ASL3

AllStarLink Version 3

https://www.allstarlink.org

GNU Affero General Public License v3.0

8 stars 1 forks source link

Add support for Hotspot COR LED #70

Open tsawyer opened 2 weeks ago

tsawyer commented 2 weeks ago

This issue is to create an easy way for users to add COR LED support to their hot spot via the asl-menu.

Add [event-hs_led] stanza to default rep.conf [node-main](!) template. Obviously, all new installs then come with it.
```
[event-hs_led]
cop,62,GPIO4:1 = c|t|RPT_RXKEYED
cop,62,GPIO4:0 = c|f|RPT_RXKEYED
```
Write patch or script to add [event-hs_led] to rpt.conf [node-main](!) template where it does not exist upon apt update and apt upgrade.
Modify asl-menu to add selection to add events = event-hs_led to selected node stanza.

Allan-N commented 2 weeks ago

Minimally, I don't think we want to call this [event-hs_led] because I don't believe it's a given that all Hotspot's have an LED tied to GPIO4. Maybe [event-led-gpio4].

Also, the new [events-xxx] would not be added to node-main because they are not [node-main] settings. They would be their own category/stanza.

tsawyer commented 2 weeks ago

@Allan-N Also, the new [events-xxx] would not be added to node-main because they are not [node-main] settings. They would be their own category/stanza.

You're right. That's at line 541 in rpt.conf

tsawyer commented 2 weeks ago

Added a stanza to toggle gpio4 with RPT_RXKEYED. https://github.com/AllStarLink/app_rpt/commit/605584cd23861d0718be9864a3f7d20c43870b80 @Allan-N Next step is patch or script this change to deployed user rpt.conf. Then we'll we have the option to implement this alone or in combination #71 and/or #72, or both combined.

tsawyer commented 2 weeks ago

@jxmx fyi, possible impact to next release.

Allan-N commented 2 weeks ago

I have pulled out this change. Needs more discussion about the impact and how best to manage .conf changes.