AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
5 stars 4 forks source link

rpt_config: Use yes/no instead of 1/0 as appropriate #226

Closed InterLinked1 closed 11 months ago

InterLinked1 commented 11 months ago

Example: https://github.com/InterLinked1/app_rpt/pull/225/files

echolinkdynamic is set to 1 or 0 only, so could be a yes/no setting. There are probably others like this.

tsawyer commented 11 months ago

A quick look through rpt.conf finds these including echolinkdynamic. Added what the defaults should be.

InterLinked1 commented 11 months ago

Looks like these are already parsed as booleans internally, so I'm making them bits explicitly to save space, and I'll update the config to indicate that yes/no can be used.

tsawyer commented 11 months ago

I've updated the ASL3 README https://github.com/AllStarLink/ASL3/blob/develop/README.md to reflect these changes.

InterLinked1 commented 11 months ago

I've updated the ASL3 README https://github.com/AllStarLink/ASL3/blob/develop/README.md to reflect these changes.

Just to clarify, 1/0 should still work, since ast_true will accept any "truthy" value, so this is backwards compatible. This wasn't well documented before, there hasn't been much change internally. At some point, I'll add XML documentation for the config, but probably not until the very end of this project, and that will allow for self-generating documentation of the entire config file.

tsawyer commented 11 months ago

Ok, I'll remove the that update as there is no user facing change.