AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
8 stars 6 forks source link

beagle.conf should be removed. chan_beagle has not been ported to ASL3 #280

Open KB4MDD opened 8 months ago

KB4MDD commented 8 months ago

The configuration file beagle.conf should be removed from configs/rpt. This configuration file is associated with chan_beagle which is not included in ASL3.

tsawyer commented 8 months ago

There are mentions of beagle elsewhere. Do we want to eliminate these?

cd /usr/src/app_rpt
grep -ri beagle *
apps/app_rpt/rpt_functions.c:           strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "beagle") &&
apps/app_rpt/rpt_functions.c:           !strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "beagle") &&
apps/app_rpt.c:     /* if is a BeagleBoard device */
apps/app_rpt.c:     if (!strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "beagle")) {
apps/app_rpt.c:             sprintf(buf, "RPT_BEAGLE_GPIO%d", i);
apps/app_rpt.c:     !strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "beagle") || !strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "simpleusb"))) {
apps/app_rpt.c:     !strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "beagle") || !strcasecmp(ast_channel_tech(myrpt->rxchannel)->type, "simpleusb"))) {
configs/rpt/rpt.conf:; rxchannel = Beagle/1              ; BeagleBoard
configs/rpt/beagle.conf:; noload => chan_beagle.so ;                      Beagleboard Radio Interface Channel Driver
configs/rpt/beagle.conf:; load => chan_beagle.so ;                      Beagleboard Radio Interface Channel Driver
configs/rpt/modules.conf:noload => chan_beagle.so            ; Beagleboard Radio Interface Channel Driver
InterLinked1 commented 8 months ago

I think the real question is should chan_beagle be ported, or is it no longer useful?

tsawyer commented 8 months ago

I don't think the "beagle and lox" board was ever released. No reason to port it that I can think of.

InterLinked1 commented 5 months ago

I don't think the "beagle and lox" board was ever released. No reason to port it that I can think of.

So, just to clarify, an entire channel driver was written for a board that was never released, and nobody has ever used this module? And therefore it should be removed?

InterLinked1 commented 5 months ago

I don't think the "beagle and lox" board was ever released. No reason to port it that I can think of.

So, just to clarify, an entire channel driver was written for a board that was never released, and nobody has ever used this module? And therefore it should be removed?

For example, here's a post that suggests otherwise: https://community.allstarlink.org/t/pico-node-is-now-a-reality/8544

In my experience with projects like this, I would rather err on the side of caution and port chan_beagle over if there's the slightest chance that it's not irrelevant. The last thing that's needed is for someone to say "ASL3 doesn't support chan_beagle" and five years later, everyone will still believe it and be running ASL2. This is exactly what happened with DAHDI. It's very hard to change people's opinions about something once they've formed it.

jxmx commented 5 months ago

Is this really a blocker for the beta release @InterLinked1 @tsawyer ?

InterLinked1 commented 5 months ago

Is this really a blocker for the beta release @InterLinked1 @tsawyer ?

Well, there shouldn't be a sample config provided for a module that doesn't exist... the module is essentially ported now except for one particular issue. I think it's worth resolving now vs than later if it would be simple to do, for the reason I stated above, but if it's more involved it could be moved.

tsawyer commented 5 months ago

Is this really a blocker for the beta release @InterLinked1 @tsawyer ?

No, not a blocker.

I don't know what's involved in the fix... not sure how much coding. Would ASL3 run on the BeagleBoard? Would need to be the ASL3 menu I suppose.

I noticed the post mentioned above is 14 years old and the URL in that post is dead. I think this is a dead product that never got off the ground.

I have a lox prototype. I don't think it was ever in production.

I say we consider this is no longer supported. I don't think we'll get any push back.

jxmx commented 5 months ago

Moved to ASL Stable Release project and removed from Beta Release project.