search

AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
4 stars 2 forks source link

chan_simpleusb: simpleusb.conf rxboost setting not functional #293

Closed tsawyer closed 3 months ago

tsawyer commented 4 months ago

Changing the rxboost setting to 0 or 1 makes no difference. It appears the attenuator is always inserted as the rxmixerset must be 850 regardless of the rxboost setting. 

rxboost = 0  ; 0 = 20db attenuator inserted, 1= 20db attenuator removed
; Set to 1 for additonal gain if using a low-level receiver output
InterLinked1 commented 4 months ago

Aside from that, this looks like a boolean setting, in which case I think it should be configured as "yes" or "no", not "1" or "0. I may have to make a pass through all the configuration and look for other boolean settings that should be changed.

tsawyer commented 4 months ago

Setting it to "yes" did not appear to remove the attenuator.

I may have to make a pass through all the configuration and look for other boolean settings that should be changed.

Ones and zeros for boolean are everywhere in the configs.

InterLinked1 commented 4 months ago

I may have to make a pass through all the configuration and look for other boolean settings that should be changed.

Ones and zeros for boolean are everywhere in the configs.

Yup, I think we should update that all before the release, to make it more user friendly. This is fairly minor, mainly a cosmetic change, so should be able to sneak that in.

tsawyer commented 4 months ago

Obviously the .conf files will require updating and perhaps the menus @Allan-N is building.

Allan-N commented 4 months ago

Obviously the .conf files will require updating and perhaps the menus @Allan-N is building.

I will be watching the commit logs and, if needed, will update the menus.

tsawyer commented 3 months ago

Turns out the CM119B (which is my device) is hardcoded to rxboost always on. Will comment confs and close with PR.