search

AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
3 stars 2 forks source link

Issue 300 #301

Closed tsawyer closed 3 months ago

tsawyer commented 3 months ago

Updated [radio-secure] with black/white list rename.

Resolves #300

tsawyer commented 3 months ago

Something seems to be wrong after the name changes. Please hold for now.

tsawyer commented 3 months ago

This is ready to go. @InterLinked1. Feel free to merge it you's happy with it.

InterLinked1 commented 3 months ago

This is ready to go. @InterLinked1. Feel free to merge it you's happy with it.

I think technically you want to "request reviewer" not assign it to me, which would be if I was working on the issue myself.

The dialplan itself looks fine to me. I wasn't following this closely, what is this change for, exactly, is it just to use different phrasing? The only thing I can think of is the builtin BLACKLIST function is hardcoded to use the blacklist db tree, so if anyone was using that (or wanted to), it would no longer work. If that's not an issue, then it doesn't matter.

I think @Allan-N suggested this change so I'd like his review, if he thinks it's good, it could be squashed and merged.