search

AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
9 stars 9 forks source link

Simpleusb-tune-menu COS Output Logic #329

Closed tsawyer closed 4 months ago

tsawyer commented 6 months ago

From the simple-tune-menu when both COR Input and CTCSS Input are set to Off COS Output is Keyed. If an input is off it should have no role determining COS Output which should be Clear by default. A USB device must be connected to duplicate this issue. Both a URI and a RA42M exhibit this behavior. 

Please enter your selection now: v
Receiver/Transmitter Status Display:
  COS   | CTCSS  | COS   | PTT
 Input  | Input  | Out   | Out
 Off    | Off    | Keyed | Keyed
KB4MDD commented 6 months ago

The COS Output is derived from an internal variable maintained by the channel driver. Apparently, this issue existed before these changes (I did not update the 'rxkeyed' variable').

Is there a case where we turn off COS input and CTCSS input? (No one could ever key the repeater.)

tsawyer commented 6 months ago

Both off is a good test to see if the logic is correct. It's showing that inputs are not ignored when off. In any case, I wouldn't think both off should set COS Output keyed.

There is a real-world need to have the cos off and ctcss active. It shows the sensitivity and coast of ctcss.

This on the "Stable" release indicating that it not need be fixed for the first beta.

tsawyer commented 6 months ago

... (No one could ever key the repeater.)

More concerning is the node is always keyed.

KB4MDD commented 6 months ago

Unfortunately this was how the driver was coded. The author never expected that both would be disabled. This should be easy to fix

tsawyer commented 6 months ago

Ok, please fix. No hurry on this.