[rpt] HTTP registrations incorrectly showed as "Registered"

[Allan-N]

When attempting to register a node w/HTTP and when not providing a valid node and password the status was incorrectly being reported as "Registered". This was because the text of the response "message" was not being checked.

One could argue that this would be better handled by having the registration server respond to the request with an non "2XX" code. Unfortunately, this is how the registration server was setup years ago. Changing (correcting) the behavior would require server changes and possible changes to this code. We would also need to ensure that any older (already deployed) systems would continue to function correctly.

For now, we will check the HTTP response text (as was done in the past).

[tsawyer]

I think we're good.

With wrong password for 2509:

rpt show registrations
Host                                           Username    Perceived                            Refresh  State
162.248.92.131:443                             25334       47.153.23.156:4569                       179  Registered
34.105.111.212:443                             2509        <Unregistered>                             0  Not Registered
2 HTTP registrations.

and now for 25334 as well

rpt show registrations
Host                                           Username    Perceived                            Refresh  State
34.105.111.212:443                             25334       <Unregistered>                             0  Not Registered
34.105.111.212:443                             2509        <Unregistered>                             0  Not Registered
2 HTTP registrations.

and after a dns change

Host                                           Username    Perceived                            Refresh  State
34.105.111.212:443                             25334       <Unregistered>                             0  Not Registered
162.248.92.131:443                             2509        <Unregistered>                             0  Not Registered
2 HTTP registrations.

put back correct password

rpt show registrations
Host                                           Username    Perceived                            Refresh  State
162.248.92.131:443                             25334       47.153.23.156:4569                       179  Registered
34.105.111.212:443                             2509        47.153.23.156:4569                       179  Registered
2 HTTP registrations.

[Allan-N]

Tim OK'd merging this change.