search

AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
5 stars 4 forks source link

Update configs for missing options #357

Open KB4MDD opened 1 month ago

KB4MDD commented 1 month ago

This updates simpleusb and usbradio config files for missing parallel port options.

tsawyer commented 1 month ago

Have we sorted out how to get config file changes out to users?

Allan-N commented 1 month ago

Have we sorted out how to get config file changes out to users?

AFAIK, we have not yet figured this out. @jxmx, any thoughts?

jxmx commented 1 month ago

I think we need to have a larger, strategic discussion on what problem(s) we're trying to architect for when we're talking about "getting config file changes out to users". For this fix, I think it should just be merged and appear in the next release when needed. I would assume that the user base which needs an actual parallel port in 2024 is vanishingly small AND that user base that is nursing equipment along that still has one should be able to edit a text file.

In general, we should likely talk about breaking up some of these monolithic configuration files and make good use of the include ability inside the configuration files. And since Asterisk seems to properly obey "last directive wins" we could create a set of includes that are marked "DO NOT EDIT THIS" and then forcefully blow them away on upgrades with a postinst script when we need to.