AllStarLink / app_rpt

Refactoring and upgrade of AllStarLink's app_rpt, etc.
9 stars 8 forks source link

Pulls for Post-Pull Review by Naveen #376

Closed Allan-N closed 3 months ago

Allan-N commented 3 months ago

Others have made pull requests to correct reported issues. Per Tim, these pulls need to be reviewed.

If OK, please check each pull request. If changes are requested/needed, please file a new issue.

InterLinked1 commented 3 months ago

Others have made pull requests to correct reported issues. Per Tim, these pulls need to be reviewed.

If OK, please check each pull request. If changes are requested/needed, please file a new issue.

Sorry for the delay here.

363 and 373 look completely good. 366 didn't follow commit/coding guidelines, but there is no point making another change just to address that. Somebody can get that when going through and addressing that issue en masse later. 372 it might be nice to have a warning if the original config setting was invalid, but not too sure what the context is there.