search

AllTheDucks / jshack-v1

JSHack Version One
8 stars 3 forks source link

Bad JS can make it impossible to disable a broken hack. #2

Closed shaneargo closed 7 years ago

shaneargo commented 7 years ago

If you create a hack that breaks the drop down menus, it becomes impossible to open the drop down to disable the broken hack, thus making it impossible to fix.

Two possible solutions are:

  1. Have a kill switch which disables all enabled hacks. Make sure the button is accessible without javascript.
  2. Do not inject hacks into the JS Hack configuration pages.
shaneargo commented 7 years ago

Fixed by commit 1503ef31053be1a2b0c5f1028825f2a6684cda90 which enables the administrator to suspend injection with the click of a button.

Also fixed by commit d061b7cfd7eda2dff33fd021c878b524435a3c21 which automatically restricts injection to pages outside of JS Hack, allowing you to disable an offending packaged even if the dropdowns would otherwise be broken.