search

AllTheDucks / jshack-v1

JSHack Version One
8 stars 3 forks source link

Add Node Restriction to JS Hacks #3

Closed Sephster closed 5 years ago

Sephster commented 5 years ago

At the University of Edinburgh, we had a requirement to restrict functionality for a group of courses. We use the institutional hierarchy nodes extensively so could leverage this as a natural way to group the courses we wanted to apply the hack to.

This pull request adds the ability to add a hack by an institutional node. It upgrades the version to 1.1.0 as this is a new feature of JS Hacks.

Thank you for providing this building block. It is very useful and we are keen to contribute back in any way we can. Many thanks for your time.

shaneargo commented 5 years ago

Hi Andrew,

Thanks for the pull request! From a glance, it looks perfect.

Currently, Wiley is on holidays and I am super busy (partly because Wiley is on holidays). I'll have a closer as soon as I get a chance.

Cheers, Shane.

shaneargo commented 5 years ago

Thanks Andrew,

Everything looks great.

We have decided that we'd prefer the version number to be v1.0.12 instead of v1.1.0. We've added other small featured before without incrementing the minor version, so we'd prefer go that way again. Could you make this little change, and then I'd be delighted to merge.

Thank you so much for your contribution.

Cheers, Shane.

Sephster commented 5 years ago

Hi Shane, no problem. Thanks for reviewing this. I've lowered the version number to 1.0.12 as requested. Many thanks, Andrew