search

AllTheDucks / jshack-v1

JSHack Version One
8 stars 3 forks source link

Update for SaaS #4

Closed Sephster closed 5 years ago

Sephster commented 5 years ago

We are currently moving our Blackboard instance to a SaaS environment. During testing, we realised we couldn't access the menus to configure JSHacks as the building block section in the admin panel has disappeared.

This PR updates JSHacks so that it is now listed under the Tools panel instead of within the Building Blocks section.

Sephster commented 5 years ago

Hi @shaneargo - I was wondering if you could advise on a rough timescale for this PR getting reviewed? No real rush from our side but my service team are hoping to put it onto our test SaaS environment soon. We can go with a local build but would prefer to use the official one with these changes if they are accepted.

If there is any help I can give to help progress this issue forwards please give me a shout and I will do my best to assist you.

Many thanks, Andrew

shaneargo commented 5 years ago

Hi @Sephster,

Sorry for the slow response. @wileyfuller is away on leave at the moment, and I wanted to talk to him before responding.

Can you please provide a little more context about why this is needed?

Our understanding of the SaaS environment is that the "Building Blocks" link in the System Admin tab was still there (and even the "Installed Tools" page was still accessible, you just can't install or configure building blocks). Is this not the case?

Cheers, Shane.

Sephster commented 5 years ago

No problem at all. I believe that the Building Blocks menu has been removed but have asked the service team at my university to provide a screenshot which I can pass on to you.

At the moment I've just tested this on our locally hosted version of Blackboard as I don't have access to our test SaaS environment, but made these changes based on feedback from our service team.

I will be in touch as soon as I have a screenshot to verify the menu structure change.

Sephster commented 5 years ago

Hi @shaneargo - apologies for the delay in responding. My initial understanding of this work was slightly inaccurate.

The building blocks menu is now in a new section called Integrations. Previously it was in a section called Building Blocks on the main Sys Admin page.

When you click on the Building Blocks link, the page that loads no longer has the JSHacks option displayed, presumably because of the menu structure change.

I had been asked by our service team to move the JSHacks link to the tools and utilities section as they felt it was a more appropriate location than the Integrations section. I've attached a photo to show the changes in the menu strucutre and the missing JSHacks link.

image

image

shaneargo commented 5 years ago

Hi @Sephster,

It appears as though this might be an issue with this specific version of Bb. Another JS Hack user has emailed me with the same issue.

Having said that, even if Bb were to fix it, I am not sure that it makes sense for JS Hack to live in that menu any more. It might be best to move it to the Tool menu anyway.

I am crazy busy right now. I hope to get a chance to look at this in the coming days.

Cheers, Shane.

Sephster commented 5 years ago

Thanks @shaneargo - much appreciated for taking the time to look at this.

Sephster commented 5 years ago

Thanks for merging this @shaneargo and cheers for taking the time to review it.

shaneargo commented 5 years ago

No worries @Sephster. Sorry it took me so long. We've been very busy. You can download the official build from the releases page: https://github.com/AllTheDucks/jshack-v1/releases/tag/v1.1.13