search

AllTheMods / ATM-2

All the Mods 2
2 stars 2 forks source link

Connection Lost Timed Out #53

Open Ricket opened 7 years ago

Ricket commented 7 years ago

Our ATM2 server has an issue where sometimes we try to log in, and we see a couple chunks and then nothing else loads, and about 10-15 seconds later we get timed out:

image

After this, our server thinks the user is still logged in for at least several minutes. Used to be more like 30-40 minutes, until I optimized Mekanism (latest version has my optimizations, highly recommend updating it in the next pack release).

Today I finally was able to have the profiler running while I had the issue, so here's the dump of the reason behind that long delay:

image

ATM2 pack version 0.73, I have updated Mekanism to latest (with the improved performance fixes).

Will be an ongoing thread until we get to the bottom of this. My next steps include looking at that method source to see if the removeAll calls are obvious; probably taking a memory dump as early as possible in this bug next time I repro it; possibly hook a debugger and step through the method. But I figured it was time to open this thread now that I have a foothold.

Ricket commented 7 years ago

In my deobf'd forge src, it's these two lines:

        this.tickableTileEntities.removeAll(this.tileEntitiesToBeRemoved);
        this.loadedTileEntityList.removeAll(this.tileEntitiesToBeRemoved);

I definitely need to grab a memory snapshot and see what is in that list.

Ricket commented 7 years ago

Opened forge issue: https://github.com/MinecraftForge/MinecraftForge/issues/4238