[Bug]: No Bloodmagic life essence on kill while you have Everlasting ability Str

Possible Fixes

Yes

Modpack Version

1.0.7

What happened?

I was killing no ai spawned villagers from a spawner and was not getting LP very often. it was like 1 in 10 kills.

Found out by trial and error that the more you remove strength from the everlasting abilities the more frequent i would get LP. Removal of Str completely fixes the issues and you always get LP again.

It would seem its an odd interaction between the extra str and the auto kill function of the Dagger of Sacrifice. my guess is that some value is going negative and not granting the LP. like the villager would have negative life. might be able to replicate it with just a str potion as well if that is the case.

Update: Got some info from my report in Blood magic bug report for this that seems accurate: stellanera98 "much like every other variant of sacrifice the dagger works off of the health sacrificed which in this case is the health remaining after being hit. Im not sure this is intended to be this way but I would guess that if not the LivingHurtEvent would have been used instead of the item method called when damaging a mob.

I've been testing this with just blood magic and executing a villager with full health without strength gives 1900 lp (20 health - 1 damage = 19, 19 * 100 = 1900, checks out). Doing the same thing with strength 5 only nets 400 lp since the melee attack dealt 16 damage

If you actually got nothing from the villagers they might have been out of range of the altar when you hit them or already took 3.5+ damage"

Summary: My issue was 2 fold, low health mobs due to fall and high strength possibly bringing the return LP below some threshold of life to get anything at all.

latest.log

https://gist.github.com/Warzer1/f7df188cce0cca64a7b341ecc9656801

Developer reports

No response

AllTheMods / All-the-mods-9-Sky